Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conn: fix lost connection when insert from select panic cause by out of memory quota (#12090) #12127

Merged
merged 3 commits into from Sep 11, 2019
Merged

conn: fix lost connection when insert from select panic cause by out of memory quota (#12090) #12127

merged 3 commits into from Sep 11, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry-pick #12090

@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 10, 2019
tangenta
tangenta approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

@crazycs520 merge failed.

@zz-jason
Copy link
Member

/rebuild

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 11, 2019
Merged
@sre-bot sre-bot merged commit c9346c4 into pingcap:release-3.0 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crazycs520 @sre-bot @zz-jason @bb7133 @tangenta